test: add mustCall to openssl-client-cert-engine#27474
Closed
li-boxuan wants to merge 1 commit intonodejs:masterfrom
Closed
test: add mustCall to openssl-client-cert-engine#27474li-boxuan wants to merge 1 commit intonodejs:masterfrom
li-boxuan wants to merge 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
addons
sam-github
suggested changes
Apr 29, 2019
Contributor
sam-github
left a comment
sam-github
left a comment
There was a problem hiding this comment.
Thanks, could you address the one comment, please? Otherwise, looks good.
Trott
approved these changes
Apr 29, 2019
jasnell
approved these changes
Apr 29, 2019
Trott
added
the
author ready
Collaborator
Contributor
Author
|
Can anyone suggest why this test https://ci.nodejs.org/job/node-test-commit-freebsd/26021/ didn't pass? I guess it's unrelated to my PR, right? |
Contributor
|
@li-boxuan It does not look related to this PR. I've started a rebuild (✔️) of it now and hopefully it will pass and we can land this. |
Contributor
|
Landed in c903c99. 🎉 |
danbev
pushed a commit
that referenced
this pull request
May 3, 2019
PR-URL: #27474 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 4, 2019
PR-URL: #27474 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This was referenced May 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes